DaqianLiao opened a new issue, #15898:
URL: https://github.com/apache/dolphinscheduler/issues/15898

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   When executing the updateWorkerNodes method, since we need to update the 
workerNodeInfo list,  but we use the workerGroupWriteLock object. It is not OK !
   
   private void updateWorkerNodes() {
           workerGroupWriteLock.lock();
           try {
               Map<String, String> workerNodeMaps = 
registryClient.getServerMaps(RegistryNodeType.WORKER);
               for (Map.Entry<String, String> entry : 
workerNodeMaps.entrySet()) {
                   workerNodeInfo.put(entry.getKey(), 
JSONUtils.parseObject(entry.getValue(), WorkerHeartBeat.class));
               }
           } finally {
               workerGroupWriteLock.unlock();
           }
       }
   
   ### What you expected to happen
   
   When executing the updateWorkerNodes method, since we need to update the 
workerNodeInfo list, we need to use the workerNodeInfoWriteLock object.
   
   ### How to reproduce
   
   The modified code is as follows:
   
   private void updateWorkerNodes() {
           workerNodeInfoWriteLock.lock();
           try {
               Map<String, String> workerNodeMaps = 
registryClient.getServerMaps(RegistryNodeType.WORKER);
               for (Map.Entry<String, String> entry : 
workerNodeMaps.entrySet()) {
                   workerNodeInfo.put(entry.getKey(), 
JSONUtils.parseObject(entry.getValue(), WorkerHeartBeat.class));
               }
           } finally {
               workerNodeInfoWriteLock.unlock();
           }
       }
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   3.2.x
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to