zhuangchong commented on code in PR #15912:
URL:
https://github.com/apache/dolphinscheduler/pull/15912#discussion_r1579266932
##########
dolphinscheduler-ui/src/views/projects/workflow/definition/components/start-modal.tsx:
##########
@@ -505,16 +504,13 @@ export default defineComponent({
label={t('project.workflow.parallelism')}
path='expectedParallelismNumber'
>
- <NCheckbox v-model:checked={this.parallelismRef}>
- {t('project.workflow.custom_parallelism')}
- </NCheckbox>
- <NInput
- allowInput={this.trim}
- disabled={!this.parallelismRef}
+ <NInputNumber
placeholder={t(
'project.workflow.please_enter_parallelism'
)}
v-model:value={this.startForm.expectedParallelismNumber}
+ max='100'
+ min='1'
Review Comment:
I have encountered a real scenario where the user needs to supplement three
years of data. After selecting the parallel mode, 1500+ workflow instances are
generated at one time, which directly causes the dolphinscheduler worker
service to go down. I suggest that there is an upper limit to limit it. We can
discuss this upper limit. How much is appropriate to set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
