sdhzwc commented on code in PR #15920:
URL:
https://github.com/apache/dolphinscheduler/pull/15920#discussion_r1580532403
##########
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-athena/src/main/java/org/apache/dolphinscheduler/plugin/datasource/athena/AthenaDataSourceChannelFactory.java:
##########
@@ -32,6 +33,6 @@ public DataSourceChannel create() {
@Override
public String getName() {
- return "athena";
+ return DbType.ATHENA.getDescp();
Review Comment:
> What about change the descp to `identify` or `name` in DbType, since descp
means description, this is easy to be changed.
I suggest change it to this (DbType.ATHENA.name().toLowerCase()) Or add a
field name to the DbType
The descp field I would recommend keeping，What do you recommend?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
