sdhzwc commented on issue #15936: URL: https://github.com/apache/dolphinscheduler/issues/15936#issuecomment-2095106016
> > > > > Good idea, do you have any designs? > > > > > > > > > > > > 1, the first step in the database to increase param_data_type field default value is VARCHAR 2, the second step to modify the add, modify, query logic 3, the third step is to modify the corresponding loading logic 4, and finally increase the UI and UT > > > > > > > > > The design is too simple, since this is a new feature, please change the issue to [DSIP](https://github.com/apache/dolphinscheduler/issues/14102) and provide the detail design, then we can discuss the design. > > > Startup parameters/global parameters/task parameters also need to have types, otherwise, this will be very strange and think of as a bug. > > > > > > In fact, this is not a new feature, the parameter priority and loading order is not changed, just optimize the type of parameter values, from the default VARCHAR to now custom type > > Right now, we don't support `types` in DS project params/workflow params/ startup params, this issue is want to support this, so this is a new feature. > > You changed the API interface, this is an incompatible change, but it doesn't announce in the issue/PR. The worst thing that can happen is that the user cp's this PR and the original interface will be unusable. > > This is why I request a DSIP. > > In the description and PR, I didn't see there exists a validation step, this means I can create a parameter with the type `int` and value `tom`? This is unacceptable. I understand what you mean, in fact, the new data value field, does not affect its original logic, because the default value of the field in the database is VARCHAR, in fact, has done a compatible operation! In fact, I feel that there is a point that really need to be optimized, that is, the global parameters, start parameters, if only the project parameters, custom parameters are indeed a little strange! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
