qingwli commented on code in PR #15935:
URL:
https://github.com/apache/dolphinscheduler/pull/15935#discussion_r1590489619
##########
deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-master.yaml:
##########
@@ -122,10 +122,10 @@ spec:
{{- else }}
emptyDir: {}
{{- end }}
- {{- include "dolphinscheduler.sharedStorage.volume" . | nindent 8 }}
- name: config-volume
configMap:
name: {{ include "dolphinscheduler.fullname" . }}-configs
+ {{- include "dolphinscheduler.sharedStorage.volume" . | nindent 8 }}
Review Comment:
Just change from line115 to line 128?
##########
deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-worker.yaml:
##########
@@ -133,11 +133,6 @@ spec:
{{- else }}
emptyDir: {}
{{- end }}
- {{- else }}
- - name: {{ include "dolphinscheduler.fullname" . }}-worker-data
- emptyDir: {}
- - name: {{ include "dolphinscheduler.fullname" . }}-worker-logs
- emptyDir: {}
Review Comment:
> Seems like these lines shouldn't be removed?
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
