ruanwenjun commented on code in PR #15932:
URL:
https://github.com/apache/dolphinscheduler/pull/15932#discussion_r1590526073
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/AlertDao.java:
##########
@@ -271,10 +270,11 @@ public void sendTaskTimeoutAlert(ProcessInstance
processInstance, TaskInstance t
}
/**
- * List alerts that are pending for execution
+ * List pending alerts which id > minAlertId and status = {@link
AlertStatus#WAIT_EXECUTION} order by id asc.
*/
- public List<Alert> listPendingAlerts() {
- return
alertMapper.listingAlertByStatus(AlertStatus.WAIT_EXECUTION.getCode(),
QUERY_ALERT_THRESHOLD);
+ public List<Alert> listPendingAlerts(int mixAlertId) {
+ return alertMapper.listingAlertByStatus(mixAlertId,
AlertStatus.WAIT_EXECUTION.getCode(),
+ QUERY_ALERT_THRESHOLD);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
