ruanwenjun commented on code in PR #15945:
URL:
https://github.com/apache/dolphinscheduler/pull/15945#discussion_r1595012128
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProjectParameterController.java:
##########
@@ -61,24 +61,27 @@ public class ProjectParameterController extends
BaseController {
@Operation(summary = "createProjectParameter", description =
"CREATE_PROJECT_PARAMETER_NOTES")
@Parameters({
@Parameter(name = "projectParameterName", description =
"PROJECT_PARAMETER_NAME", schema = @Schema(implementation = String.class)),
- @Parameter(name = "projectParameterValue", description =
"PROJECT_PARAMETER_VALUE", schema = @Schema(implementation = String.class))
+ @Parameter(name = "projectParameterValue", description =
"PROJECT_PARAMETER_VALUE", schema = @Schema(implementation = String.class)),
+ @Parameter(name = "projectParameterDataType", description =
"PROJECT_PARAMETER_DATA_TYPE", schema = @Schema(implementation = String.class))
})
@PostMapping()
@ResponseStatus(HttpStatus.CREATED)
@ApiException(CREATE_PROJECT_PARAMETER_ERROR)
public Result createProjectParameter(@Parameter(hidden = true)
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@Parameter(name = "projectCode",
description = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam("projectParameterName")
String projectParameterName,
- @RequestParam(value =
"projectParameterValue") String projectParameterValue) {
+ @RequestParam(value =
"projectParameterValue") String projectParameterValue,
+ @RequestParam(value =
"projectParameterDataType") String projectParameterDataType) {
Review Comment:
```suggestion
@RequestParam(value =
"projectParameterDataType", defaultValue = "VARCHAR") String
projectParameterDataType) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
