caishunfeng commented on code in PR #15933:
URL:
https://github.com/apache/dolphinscheduler/pull/15933#discussion_r1597414527
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/UiPluginController.java:
##########
@@ -85,4 +89,21 @@ public Result queryUiPluginDetailById(@Parameter(hidden =
true) @RequestAttribut
Map<String, Object> result =
uiPluginService.queryUiPluginDetailById(pluginId);
return returnDataList(result);
}
+
+ /**
+ * obtain project version and address
+ *
+// * @param loginUser login user
+// * @param userId token for user
Review Comment:
```suggestion
```
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UiPluginServiceImpl.java:
##########
@@ -45,6 +53,14 @@ public class UiPluginServiceImpl extends BaseServiceImpl
implements UiPluginServ
@Autowired
PluginDefineMapper pluginDefineMapper;
+ @Autowired
+ DsVersionMapper dsVersionMapper;
+
+ @Autowired
+ private DsVersionDao dsVersionDao;
Review Comment:
It's better to use dao in service but not mapper.
```suggestion
@Autowired
private DsVersionDao dsVersionDao;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
