ruanwenjun commented on code in PR #15987:
URL:
https://github.com/apache/dolphinscheduler/pull/15987#discussion_r1599956640
##########
dolphinscheduler-scheduler-plugin/dolphinscheduler-scheduler-quartz/src/main/java/org/apache/dolphinscheduler/scheduler/quartz/QuartzCornTriggerBuilder.java:
##########
@@ -81,14 +81,28 @@ public CronTrigger build() {
JobKey jobKey = QuartzJobKey.of(projectId,
schedule.getId()).toJobKey();
TriggerKey triggerKey = TriggerKey.triggerKey(jobKey.getName(),
jobKey.getGroup());
+
+ CronScheduleBuilder cronScheduleBuilder =
CronScheduleBuilder.cronSchedule(schedule.getCrontab())
+ .inTimeZone(DateUtils.getTimezone(schedule.getTimezoneId()));
+
+ switch (schedule.getMisfirePolicy()) {
+ case DONOTHING:
+ cronScheduleBuilder.withMisfireHandlingInstructionDoNothing();
+ break;
+ case FIREANDPROCEED:
+
cronScheduleBuilder.withMisfireHandlingInstructionFireAndProceed();
+ break;
+ case IGNOREMISFIRES:
+ default:
+
cronScheduleBuilder.withMisfireHandlingInstructionIgnoreMisfires();
+ break;
+ }
+
Review Comment:
Is this PR finished? how can we set this property?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
