This is an automated email from the ASF dual-hosted git repository.

wenjun pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new 5867bee95d Fix task instance which status is dispatch will not be 
failover (#16107)
5867bee95d is described below

commit 5867bee95d27bf8b638b497bfc6c83b652ff50ad
Author: Wenjun Ruan <[email protected]>
AuthorDate: Wed Jun 5 11:33:41 2024 +0800

    Fix task instance which status is dispatch will not be failover (#16107)
---
 .../server/master/runner/WorkflowExecuteRunnable.java             | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
 
b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
index c35fd9991f..919ca844c4 100644
--- 
a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
+++ 
b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
@@ -1219,12 +1219,12 @@ public class WorkflowExecuteRunnable implements 
IWorkflowExecuteRunnable {
                         || state == TaskExecutionStatus.DISPATCH
                         || state == TaskExecutionStatus.SUBMITTED_SUCCESS
                         || state == TaskExecutionStatus.DELAY_EXECUTION) {
-                    // try to take over task instance
-                    if (state == TaskExecutionStatus.SUBMITTED_SUCCESS || 
state == TaskExecutionStatus.DELAY_EXECUTION
-                            || state == TaskExecutionStatus.DISPATCH) {
+                    if (state == TaskExecutionStatus.SUBMITTED_SUCCESS
+                            || state == TaskExecutionStatus.DELAY_EXECUTION) {
                         // The taskInstance is not in running, directly 
takeover it
                     } else if (tryToTakeOverTaskInstance(existTaskInstance)) {
-                        log.info("Success take over task {}", 
existTaskInstance.getName());
+                        // If the taskInstance has already dispatched to 
worker then will try to take-over it
+                        log.info("Success take over task {} -> status: {}", 
existTaskInstance.getName(), state);
                         continue;
                     } else {
                         // set the task instance state to fault tolerance

Reply via email to