caicancai commented on PR #16142: URL: https://github.com/apache/dolphinscheduler/pull/16142#issuecomment-2164232914
> https://github.com/apache/dolphinscheduler/blob/a13eacd61c7a098bb820b1e656889bc5ed9e5a5e/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistryClient.java#L188-L200 > > IMHO at least you need to verify the behavior of injected registryClient mock after calling `masterRegistryClient.deregister()`. To make things fully covered, you may also test the exception handling block, which is no necessary in this case though. Simply calling `masterRegistryClient.deregister()` is not a meaningful test case. Thanks, I will close this pr and see if there is any way to improve it later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
