ruanwenjun commented on code in PR #16193:
URL:
https://github.com/apache/dolphinscheduler/pull/16193#discussion_r1651078586
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java:
##########
@@ -362,24 +362,10 @@ private TaskConstants() {
*/
public static final String DATA_QUALITY_JAR_DIR = "data-quality.jar.dir";
- public static final String TASK_TYPE_CONDITIONS = "CONDITIONS";
-
- public static final String TASK_TYPE_SWITCH = "SWITCH";
-
- public static final String TASK_TYPE_SUB_PROCESS = "SUB_PROCESS";
-
- public static final String TASK_TYPE_DYNAMIC = "DYNAMIC";
-
- public static final String TASK_TYPE_DEPENDENT = "DEPENDENT";
-
- public static final String TASK_TYPE_SQL = "SQL";
Review Comment:
This has been moved into `xxTaskChannelFactory`, this should be controlled
by task plugin, otherwise it will be hard to manage these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
