ruanwenjun commented on code in PR #16220:
URL:
https://github.com/apache/dolphinscheduler/pull/16220#discussion_r1654777678
##########
dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/pages/security/SecurityPage.java:
##########
@@ -68,58 +68,58 @@ public SecurityPage(RemoteWebDriver driver) {
public <T extends SecurityPage.Tab> T goToTab(Class<T> tab) {
if (tab == TenantPage.class) {
- new WebDriverWait(driver,
Duration.ofSeconds(60)).until(ExpectedConditions.urlContains("/security"));
Review Comment:
The url is incorrect, I added
```
new WebDriverWait(driver,
Duration.ofSeconds(60)).until(ExpectedConditions.urlContains("/security/tenant-manage"));
```
at the below
##########
dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/pages/project/workflow/TaskInstanceTab.java:
##########
@@ -35,7 +35,8 @@
@Getter
public final class TaskInstanceTab extends NavBarPage implements
ProjectDetailPage.Tab {
- @FindBy(className = "items-task-instances")
+
+ @FindBy(css = "tbody > .n-data-table-tr")
Review Comment:
The form doesn't have id, and it's hard to use xpath since all class is not
unique
![Uploading image.png…]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
