pegasas commented on code in PR #16271:
URL:
https://github.com/apache/dolphinscheduler/pull/16271#discussion_r1665305283
##########
dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-zookeeper/src/main/java/org/apache/dolphinscheduler/plugin/registry/zookeeper/ZookeeperRegistry.java:
##########
@@ -96,6 +96,24 @@ public List<ACL> getAclForPath(final String path) {
}
});
}
+
+ final String x509SubjectPrincipal =
properties.getX509SubjectPrincipal();
+ if (!Strings.isNullOrEmpty(x509SubjectPrincipal)) {
+ builder.authorization("x509",
digest.getBytes(StandardCharsets.UTF_8))
Review Comment:
how about change both digest/x509 into AuthSchema? see
https://github.com/apache/zookeeper/blob/39973dc5fddf778733e4f0370980629c07a16d67/zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/CommandAuthTest.java#L79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
