ruanwenjun commented on PR #16461: URL: https://github.com/apache/dolphinscheduler/pull/16461#issuecomment-2290377635
> > The key problem related to your issue is the async task doesn't support timeout, the async should stop once it's timeout. > > @ruanwenjun Here are two critical issues about AsyncMasterTask: > > 1. if the task is set to just warn and not fail on timeout, it will immediately enter an infinite loop after reaching the timeout period. > 2. there's a mistake in the timeout unit, should be minute not second, it exacerbates the problem. > > I think the best solution is to ignore the timeout logic here and only focus on the execution interval. The timeout event should still be handled by the stateEventhandler. Yes, there exist a bug as you mention, and you are right, the task executor don't need to care about the timeout, all timeout event should be controlled by master event engine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
