topsli commented on issue #16467: URL: https://github.com/apache/dolphinscheduler/issues/16467#issuecomment-2290921907
1. This issue is at the method of **putMasterTaskExecuteRunnable** in class **MasterTaskExecutorHolder** , which is no usages. But in the operate method of **LogicITaskInstanceKillOperationFunction** class, we can find its use _MasterTaskExecutorHolder.getMasterTaskExecutor(taskInstanceId)_ to get **masterTaskExecutor** , and then to use masterTaskExecutor to cancel task. So, it's should put **masterTaskExecutor** first in class **MasterTaskExecutorHolder** . 2.Another point of this issue at the method of **sendToSubProcess** in class **SubWorkflowLogicTask**, when new **WorkflowInstanceStateChangeEvent** object, it should use subProcessInstance.getId() to set sourceProcessInstanceId. 3.The **DynamicLogicTask** have same issue, resolve solution same to the **SubWorkflowLogicTask**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
