sdhzwc commented on PR #16450: URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2297889559
> > > > > It's better to set `modify_user` as create_user when upgrade. > > > > > > > > > > > > What needs to be adjusted? Could you specify? > > > > > > > > > It's not a good idea to make `modify_user_id` DEFAULT NULL, this will make confusion, why the create user is not null, but the modify_user_id can be null, no one can explain this. If the modify_user_id is null is this a bug? > > > To avoid this kind problem, you need to inject a value for the new column, obviously you should use create_user to inject. > > > > > > The reason is very simple. When the timer is created, it is definite. The creator is the logged-in person. At this time, there is no modification operation, so there is no need to specify the updater. I think it makes sense. If the updater is added, I think there will be ambiguity because there is no update operation yet. > > This is not a common practice, please reference the last_modify_user/last_modify_time in aws/linux. It has been changed. The value has been added when inserting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
