SbloodyS commented on code in PR #16327:
URL:
https://github.com/apache/dolphinscheduler/pull/16327#discussion_r1724485577
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/config/MasterConfig.java:
##########
@@ -48,16 +46,8 @@ public class MasterConfig implements Validator {
* The master RPC server listen port.
*/
private int listenPort = 5678;
- /**
- * The thread number used to prepare processInstance. This number
shouldn't bigger than fetchCommandNum.
- */
- private int preExecThreads = 10;
- /**
- * todo: We may need to split the process/task into different thread size.
- * The thread number used to handle processInstance and task event.
- * Will create two thread poll to execute {@link WorkflowExecuteRunnable}
and {@link TaskExecuteRunnable}.
- */
- private int execThreads = 10;
+
+ private int workflowEventBusFireThreadCount =
Runtime.getRuntime().availableProcessors() * 2 + 1;
Review Comment:
It's better to add these config to `application.yaml` and add comments in it
to let the user know its meaning. Same as
`masterSyncTaskExecutorThreadPoolSize` and
`masterAsyncTaskExecutorThreadPoolSize`.
Is it too large for `Runtime.getRuntime().availableProcessors() * 2 + 1`? I
think `Runtime.getRuntime().availableProcessors()` is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
