zhongjiajie commented on code in PR #16524: URL: https://github.com/apache/dolphinscheduler/pull/16524#discussion_r1734329111
########## dolphinscheduler-api/src/main/resources/i18n/messages_en_US.properties: ########## @@ -59,43 +52,28 @@ ALERT_PLUGIN_INSTANCE_PARAMS=alert plugin instance parameters ALERT_INSTANCE_NAME=alert instance name VERIFY_ALERT_INSTANCE_NAME_NOTES=verify alert instance name DATA_SOURCE_PARAM=datasource parameter -DB_TEST_FLAG=db test flag QUERY_ALL_ALERT_PLUGIN_INSTANCE_NOTES=query all alert plugin instances GET_ALERT_PLUGIN_INSTANCE_NOTES=get alert plugin instance operation CREATE_ALERT_GROUP_NOTES=create alert group WORKER_GROUP_TAG=worker group related operation -SAVE_WORKER_GROUP_NOTES=create worker group WORKER_GROUP_NAME=worker group name -WORKER_IP_LIST=worker ip list, eg. 192.168.1.1,192.168.1.2 QUERY_WORKER_GROUP_PAGING_NOTES=query worker group paging QUERY_WORKER_GROUP_LIST_NOTES=query worker group list DELETE_WORKER_GROUP_BY_ID_NOTES=delete worker group by id DATA_ANALYSIS_TAG=analysis related operation of task state COUNT_TASK_STATE_NOTES=count task state -COUNT_PROCESS_INSTANCE_NOTES=count process instance state -COUNT_PROCESS_DEFINITION_BY_USER_NOTES=count process definition by user +COUNT_WORKFLOW_INSTANCE_NOTES=count process instance state Review Comment: Good job, you do not missing those i18n files ########## dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/mysql/dolphinscheduler_ddl.sql: ########## @@ -16,22 +16,21 @@ */ DROP TABLE IF EXISTS `t_ds_process_task_lineage`; -CREATE TABLE `t_ds_process_task_lineage` -( - `id` int NOT NULL AUTO_INCREMENT, - `process_definition_code` bigint NOT NULL DEFAULT 0, - `process_definition_version` int NOT NULL DEFAULT 0, - `task_definition_code` bigint NOT NULL DEFAULT 0, - `task_definition_version` int NOT NULL DEFAULT 0, - `dept_project_code` bigint NOT NULL DEFAULT 0 COMMENT 'dependent project code', - `dept_process_definition_code` bigint NOT NULL DEFAULT 0 COMMENT 'dependent process definition code', - `dept_task_definition_code` bigint NOT NULL DEFAULT 0 COMMENT 'dependent task definition code', - `create_time` datetime NOT NULL DEFAULT CURRENT_TIMESTAMP COMMENT 'create time', - `update_time` datetime NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP COMMENT 'update time', - PRIMARY KEY (`id`), - KEY `idx_process_code_version` (`process_definition_code`,`process_definition_version`), - KEY `idx_task_code_version` (`task_definition_code`,`task_definition_version`), - KEY `idx_dept_code` (`dept_project_code`,`dept_process_definition_code`,`dept_task_definition_code`) +CREATE TABLE `t_ds_process_task_lineage` ( Review Comment: So our strategy for database schema is to change only the unreleased version but not the newly released version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
