ruanwenjun commented on code in PR #16575:
URL:
https://github.com/apache/dolphinscheduler/pull/16575#discussion_r1742290259
##########
dolphinscheduler-extract/dolphinscheduler-extract-master/src/main/java/org/apache/dolphinscheduler/extract/master/transportor/workflow/WorkflowBackfillTriggerRequest.java:
##########
@@ -55,8 +55,6 @@ public class WorkflowBackfillTriggerRequest {
@Builder.Default
private TaskDependType taskDependType = TaskDependType.TASK_POST;
- private CommandType execType;
Review Comment:
The command type should always be COMPLEMENT_DATA
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/lifecycle/handler/TaskStartLifecycleEventHandler.java:
##########
@@ -42,7 +42,7 @@ public void handle(final IWorkflowExecutionRunnable
workflowExecutionRunnable,
// So we need to initialize the task instance here.
// Otherwise, we cannot find the statemachine by task instance state.
if (!taskExecutionRunnable.isTaskInstanceInitialized()) {
- taskExecutionRunnable.initializeTaskInstance();
Review Comment:
Use `initializeFirstRunTaskInstance` is more accurate.
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/lifecycle/handler/TaskPauseLifecycleEventHandler.java:
##########
@@ -34,9 +34,6 @@ public void handle(final ITaskStateAction taskStateAction,
final IWorkflowExecutionRunnable
workflowExecutionRunnable,
final ITaskExecutionRunnable taskExecutionRunnable,
final TaskPauseLifecycleEvent taskPauseEvent) {
- if (!taskExecutionRunnable.isTaskInstanceInitialized()) {
- taskExecutionRunnable.initializeTaskInstance();
- }
Review Comment:
Since the task instance should already initialized here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
