wangxj3 commented on code in PR #16579:
URL:
https://github.com/apache/dolphinscheduler/pull/16579#discussion_r1753967910
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceImpl.java:
##########
@@ -267,6 +270,10 @@ public List<AuthorizationType> authorizationTypes() {
@Override
public boolean permissionCheck(int userId, String url, Logger logger) {
+ User user = processService.getUserById(userId);
+ if (user.getUserType() != UserType.ADMIN_USER) {
+ return false;
+ }
Review Comment:
> This is too restrictive. We just need to add environment control.
Do you want to add this feature to the service?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
