ruanwenjun commented on code in PR #16654:
URL:
https://github.com/apache/dolphinscheduler/pull/16654#discussion_r1776182787
##########
dolphinscheduler-dist/src/main/assembly/dolphinscheduler-bin.xml:
##########
@@ -107,6 +107,21 @@
<directoryMode>0755</directoryMode>
</fileSet>
+ <fileSet>
+ <directory>${basedir}/../config</directory>
+ <outputDirectory>conf</outputDirectory>
+ </fileSet>
+
+ <fileSet>
+ <directory>${basedir}/.././</directory>
+ <includes>
+ <include>mvnw</include>
+ <include>mvnw.cmd</include>
Review Comment:
The binary zip will not contain maven wrapper directory, can this work?
##########
.github/workflows/publish-nexus/release-asf-settings.xml:
##########
@@ -0,0 +1,34 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
https://maven.apache.org/xsd/settings-1.0.0.xsd";>
+ <servers>
+ <server>
+ <id>apache.snapshots.https</id>
+ <username>${env.ASF_USERNAME}</username>
+ <password>${env.ASF_PASSWORD}</password>
+ </server>
Review Comment:
Remove this?
##########
dolphinscheduler-dist/src/main/assembly/assembly-plugins.sh:
##########
@@ -36,12 +38,16 @@ storage-plugins
task-plugins
)
-for plugin_path in ${PLUGINS_PATH[@]}
-do
- cd $BIN_DIR/plugins/$plugin_path
- find ./* -name "*.jar" | xargs -I {} mv {} ./
- ls -d */ | xargs -I {} rm -rf {}
-done
+if [ $PLUGINS_ASSEMBLY == "true" ]; then
+ for plugin_path in ${PLUGINS_PATH[@]}
+ do
+ cd $BIN_DIR/plugins/$plugin_path
+ find ./* -name "*.jar" | xargs -I {} mv {} ./
+ ls -d */ | xargs -I {} rm -rf {}
+ done
+else
+ rm -rf $BIN_DIR/plugins/*
+fi
Review Comment:
Can we use env or jvm -D args to control this, then we can remove staging
profile.
And why we set this true in staging, since we will not upload in test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
