ruanwenjun commented on code in PR #16659:
URL:
https://github.com/apache/dolphinscheduler/pull/16659#discussion_r1778182094
##########
dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/server/NettyRemotingServer.java:
##########
@@ -66,7 +72,20 @@ class NettyRemotingServer {
private final AtomicBoolean isStarted = new AtomicBoolean(false);
- NettyRemotingServer(final NettyServerConfig serverConfig) {
+ private SslContext sslContext = null;
+
+ private NettySslConfig nettySslConfig;
+
+ public NettyRemotingServer(final NettyServerConfig serverConfig, final
NettySslConfig nettySslConfig) {
+ this.nettySslConfig = nettySslConfig;
+ if (nettySslConfig.isEnabled()) {
+ try {
+ sslContext = SslContextBuilder.forServer(new
File(nettySslConfig.getCertFilePath()),
+ new File(nettySslConfig.getKeyFilePath())).build();
+ } catch (SSLException e) {
+ throw new RuntimeException(e);
+ }
+ }
Review Comment:
NettySslConfig should as a field in NettyServerConfig and NettyClientConfig.
##########
dolphinscheduler-master/src/main/resources/application.yaml:
##########
@@ -148,6 +148,11 @@ metrics:
# Override by profile
+rpc:
+ ssl:
+ enabled: false
+ cert-file-path: /path/cert.crt
+ key-file-path: /path/private.pem
Review Comment:
Should under master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
