shouwangyw commented on code in PR #16683:
URL:
https://github.com/apache/dolphinscheduler/pull/16683#discussion_r1794771958
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/ParameterUtils.java:
##########
@@ -314,15 +314,18 @@ private static String dateTemplateParse(String
templateStr, Date date) {
/**
* handle escapes
*
- * @param inputString input string
+ * @param str input string
* @return string filter escapes
*/
- public static String handleEscapes(String inputString) {
-
- if (!StringUtils.isEmpty(inputString)) {
- return inputString.replace("%", "////%").replaceAll("[\n|\r\t]",
"_");
+ public static String handleEscapes(String str) {
+ str = StringUtils.trim(str);
+ if (StringUtils.isNotBlank(str)) {
+ str = str.replace("\\", "\\\\");
+ str = str.replace("_", "\\_");
+ str = str.replace("%", "\\%");
+ str = str.replaceAll("[\n|\r\t]", "");
Review Comment:
> This is a general processing method, and we should not modify it. Workflow
name and task name should not contain special characters such as `%`. We should
add verification and documentation when creating it.
I understand that this method is intended for special characters, and should
be able to support like fuzzy queries.
And for general processing the character `_ and \ ` should also be
supported.This is not just a processing for workflow name and task
name,validation should be implemented elsewhere.
Here are some self-tests：
<img width="1390" alt="image"
src="https://github.com/user-attachments/assets/7d23e540-04c6-4414-a309-2910a398c94c";>
<img width="1196" alt="image"
src="https://github.com/user-attachments/assets/1f4fabcf-a359-45a3-b120-ab5a5055227f";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
