SbloodyS commented on code in PR #16703:
URL:
https://github.com/apache/dolphinscheduler/pull/16703#discussion_r1811920570
##########
docs/docs/en/guide/task/flink.md:
##########
@@ -37,7 +37,7 @@ Flink task type, used to execute Flink programs. For Flink
nodes:
| Parallelism | Used to set the degree of parallelism for
executing Flink tasks.
|
| Yarn queue | Used to set the yarn queue, use `default` queue by
default.
|
| Main program parameters | Set the input parameters for the Flink program and
support the substitution of custom parameter variables.
|
-| Optional parameters | Set the flink command options, such as `-D`, `-C`,
`-yt`.
|
+| Optional parameters | Set the flink command options, such as `-D`, `-C`,
`-yt`, and support the substitution of custom parameter variables, such as
`-Dyarn.application.name=${job_name}` custom parameter job _name will be
replaced. |
Review Comment:
> Understand your idea, but i have a question: custom parameters can't be
used as task parameters? Now flink task main parameters can be replaced with
custom parameters.
I didn't say that `custom parameters can't be used as task parameters`. What
I mean is `job_name` should be added into task parameters instead of custom
parameters.
After take a look at `dev` branch, I found that the `job_name` already
exists in task params right now with
`org.apache.dolphinscheduler.plugin.task.flink.FlinkParameters#appName`. But it
is only used in flink sql. We can just simpliy add it to the flink jar mode.
And this issue can be easily solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
