SbloodyS commented on code in PR #16673:
URL: 
https://github.com/apache/dolphinscheduler/pull/16673#discussion_r1811961004


##########
.github/workflows/cluster-e2e.yml:
##########


Review Comment:
   We should not add another test module(cluster-e2e) for this PR. All you need 
to do is just add a ssl-test e2e cases. For DS cluster docker image, you can 
create different images for each servers and build it base on the standalone 
image in `docker-compose.yaml`. And override each image's `CMD` with different 
command. For more info of DS cluster image, you can take a look at 
`dolphinscheduler-dist/src/main/docker/xxx.dockerfile`.
   
   After that, you should have a normal cluster environment to run your ssl 
test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to