liunaijie opened a new issue, #16766:
URL: https://github.com/apache/dolphinscheduler/issues/16766

   ### Search before asking
   
   - [X] I had searched in the 
[DSIP](https://github.com/apache/dolphinscheduler/issues/14102) and found no 
similar DSIP.
   
   
   ### Motivation
   
   Now we support 2 kinds of parameter definition.
   1. System variable
   use `${}`
   2. Time related variable
   use `$[]`, and in this variable we also support data calculate, like 
`$[add_months(yyyyMMdd,N)]`
   
   But now we can't support the case that we need concat a fixed value with a 
dynamic value.
   like  `/tmp/${system.workflow.instance.id}`
   
   Do we need improve the parser to support more flexible definition.
   like `/tmp/$[yyyy-MM-dd]/${system.workflow.instance.id}`
   
   
   ### Design Detail
   
   
![image](https://github.com/user-attachments/assets/4939958d-1774-4af5-8082-d6abb8cd7494)
   
   
   
   refactor the current class, make each class's function clear
   create 3 parser implemention
   - InnerSystemParser  find the `${}` variable, and replace with 
parameterMap's value
   - TimeParser    find the `$[]` variable, calculate and replace time related 
placeholder
   - StringParser   find the `$<>` variable, and for loop to find other 
placeholder,  `${}`, `$[]`. replace the response with placeholder.
   
   
   ### Compatibility, Deprecation, and Migration Plan
   
   _No response_
   
   ### Test Plan
   
   Create new test and update/check exist test
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
commits-unsubscr...@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to