ailiujiarui commented on code in PR #16542:
URL:
https://github.com/apache/dolphinscheduler/pull/16542#discussion_r1828884674
##########
dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowJavaTaskE2ETest.java:
##########
@@ -121,35 +247,47 @@ public static void cleanup() {
@Test
@Order(1)
- void testCreateWorkflow() {
- WorkflowDefinitionTab workflowDefinitionPage =
- new ProjectPage(browser)
- .goTo(project)
- .goToTab(WorkflowDefinitionTab.class);
+ void testCreateFatWorkflow() {
+ FileManagePage file = new NavBarPage(browser)
+ .goToNav(ResourcePage.class)
+ .goToTab(FileManagePage.class)
+ .uploadFile(filePath + "/fat.jar");
+
+ WebDriverWait wait = WebDriverWaitFactory.createWebDriverWait(browser);
- workflowDefinitionPage
- .createWorkflow()
- .<JavaTaskForm>addTask(WorkflowForm.TaskType.JAVA)
- .script(javaContent)
+
wait.until(ExpectedConditions.visibilityOfElementLocated(By.xpath("//span[text()='fat.jar']")));
+
+ ProjectPage projectPage = new NavBarPage(browser)
+ .goToNav(ProjectPage.class);
+
+
wait.until(ExpectedConditions.visibilityOfAllElements(projectPage.projectList()));
+
+ WorkflowDefinitionTab workflowDefinitionPage = projectPage
+ .goTo(project)
+ .goToTab(WorkflowDefinitionTab.class);
+
+ WorkflowForm workflow1 = workflowDefinitionPage.createWorkflow();
+ workflow1.<JavaTaskForm>addTask(WorkflowForm.TaskType.JAVA)
+ .selectRunType("FAT_JAR")
+ .selectMainPackage("fat.jar")
+ .selectJavaResource("fat.jar")
.name("test-1")
- .addParam("today", "${system.datetime}")
.selectEnv(environmentName)
.submit()
.submit()
.name(workflow)
- .addGlobalParam("global_param", "hello world")
.submit();
Awaitility.await().untilAsserted(() ->
assertThat(workflowDefinitionPage.workflowList())
.as("Workflow list should contain newly-created workflow")
- .anyMatch(
- it -> it.getText().contains(workflow)));
+ .anyMatch(it -> it.getText().contains(workflow)));
+
workflowDefinitionPage.publish(workflow);
}
@Test
@Order(30)
- void testRunWorkflow() {
+ void testRunFatWorkflow() {
Review Comment:
The normal jar test has been added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
