reele opened a new issue, #16813:
URL: https://github.com/apache/dolphinscheduler/issues/16813

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   
https://github.com/apache/dolphinscheduler/blob/9a64534f8cd10622f96bbd10300012ceac36bd92/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/WorkflowExecutionGraph.java#L253-L256
   
   i think there should be a check to determine whether the task definition's 
flag is NO.
   
   but the task instance entity will remove the flag:
   
   
https://github.com/apache/dolphinscheduler/blob/9a64534f8cd10622f96bbd10300012ceac36bd92/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinition.java#L119-L123
   
   is there a plan or a approach to refactor that?
   
   ### What you expected to happen
   
   don't run the offline task
   
   ### How to reproduce
   
   run a workflow with a offline task
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   dev
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to