ruanwenjun commented on code in PR #16794: URL: https://github.com/apache/dolphinscheduler/pull/16794#discussion_r1847673628
########## dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql: ########## Review Comment: Please rm t_ds_relation_rule_execute_sql ########## dolphinscheduler-common/src/test/resources/sql/mysql_dml.sql: ########## @@ -38,13 +38,6 @@ DROP PROCEDURE dolphin_t_ds_tenant_insert_default; UPDATE t_ds_schedules t1 JOIN t_ds_workflow_definition t2 ON t1.workflow_definition_code = t2.code LEFT JOIN t_ds_tenant t3 ON t2.tenant_id = t3.id SET t1.tenant_code = COALESCE(t3.tenant_code, 'default'); UPDATE `t_ds_workflow_instance` SET `tenant_code` = 'default' WHERE `tenant_code` IS NULL; --- data quality support choose database -INSERT IGNORE INTO `t_ds_dq_rule_input_entry` -(`id`, `field`, `type`, `title`, `value`, `options`, `placeholder`, `option_source_type`, `value_type`, `input_type`, `is_show`, `can_edit`, `is_emit`, `is_validate`, `create_time`, `update_time`) -VALUES(30, 'src_database', 'select', '$t(src_database)', NULL, NULL, 'please select source database', 0, 0, 0, 1, 1, 1, 1, current_timestamp, current_timestamp); -INSERT IGNORE INTO `t_ds_dq_rule_input_entry` -(`id`, `field`, `type`, `title`, `value`, `options`, `placeholder`, `option_source_type`, `value_type`, `input_type`, `is_show`, `can_edit`, `is_emit`, `is_validate`, `create_time`, `update_time`) -VALUES(31, 'target_database', 'select', '$t(target_database)', NULL, NULL, 'please select target database', 0, 0, 0, 1, 1, 1, 1, current_timestamp, current_timestamp); INSERT IGNORE INTO `t_ds_relation_rule_input_entry` Review Comment: This also need to remove -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
