ruanwenjun commented on code in PR #16875:
URL:
https://github.com/apache/dolphinscheduler/pull/16875#discussion_r1871004264
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/WorkerClusters.java:
##########
@@ -134,6 +145,17 @@ public void onServerAdded(WorkerServerMetadata
workerServer) {
@Override
public void onServerRemove(WorkerServerMetadata workerServer) {
workerMapping.remove(workerServer.getAddress(), workerServer);
+ synchronized (workerGroupMapping) {
+ List<String> removeWorkerGroupAddrList =
workerGroupMapping.get(workerServer.getWorkerGroup());
+ if (removeWorkerGroupAddrList != null &&
removeWorkerGroupAddrList.contains(workerServer.getAddress())) {
+ removeWorkerGroupAddrList.remove(workerServer.getAddress());
+ if (removeWorkerGroupAddrList.isEmpty()) {
+ workerGroupMapping.remove(workerServer.getWorkerGroup());
+ } else {
+ workerGroupMapping.put(workerServer.getWorkerGroup(),
removeWorkerGroupAddrList);
+ }
Review Comment:
```suggestion
}
```
No need to put again.
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/WorkerClusters.java:
##########
@@ -126,6 +126,17 @@ WorkerServerMetadata parseServerFromHeartbeat(String
serverHeartBeatJson) {
@Override
public void onServerAdded(WorkerServerMetadata workerServer) {
workerMapping.put(workerServer.getAddress(), workerServer);
+ synchronized (workerGroupMapping) {
Review Comment:
Please add synchronized (workerGroupMapping) at `onWorkerGroupDelete`,
`onWorkerGroupAdd` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
