SbloodyS commented on code in PR #16883:
URL:
https://github.com/apache/dolphinscheduler/pull/16883#discussion_r1875141926
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/WorkerClusters.java:
##########
@@ -59,27 +62,44 @@ public Optional<WorkerServerMetadata> getServer(final
String address) {
return Optional.ofNullable(workerMapping.get(address));
}
- public List<String> getWorkerServerAddressByGroup(String workerGroup) {
+ public List<String> getDbWorkerServerAddressByGroup(String workerGroup) {
+ if (WorkerGroupUtils.getDefaultWorkerGroup().equals(workerGroup)) {
+ return UnmodifiableList.unmodifiableList(new
ArrayList<>(workerMapping.keySet()));
+ }
Review Comment:
I think we should keep the default value of worker group. If users don't
want this default value, they can modify it to other custom values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
