ruanwenjun commented on code in PR #16910:
URL:
https://github.com/apache/dolphinscheduler/pull/16910#discussion_r1899941067
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowInstanceServiceImpl.java:
##########
@@ -460,15 +470,45 @@ public Map<String, Object>
queryTaskListByWorkflowInstanceId(User loginUser, lon
List<TaskInstance> taskInstanceList =
taskInstanceDao.queryValidTaskListByWorkflowInstanceId(workflowInstanceId,
workflowInstance.getTestFlag());
+ List<TaskInstanceDependentDetails> taskInstanceDependentDetailsList =
+ setTaskInstanceDependentResult(taskInstanceList);
+
Map<String, Object> resultMap = new HashMap<>();
resultMap.put(WORKFLOW_INSTANCE_STATE,
workflowInstance.getState().toString());
- resultMap.put(TASK_LIST, taskInstanceList);
+ resultMap.put(TASK_LIST, taskInstanceDependentDetailsList);
result.put(DATA_LIST, resultMap);
putMsg(result, Status.SUCCESS);
return result;
}
+ private List<TaskInstanceDependentDetails>
setTaskInstanceDependentResult(List<TaskInstance> taskInstanceList) {
Review Comment:
```suggestion
private List<TaskInstance>
setTaskInstanceDependentResult(List<TaskInstance> taskInstanceList) {
```
We should return `List<TaskInstance>` rather than
`List<TaskInstanceDependentDetails>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
