ruanwenjun commented on code in PR #17037:
URL:
https://github.com/apache/dolphinscheduler/pull/17037#discussion_r1990509152
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/ClusterManager.java:
##########
@@ -48,12 +49,15 @@ public class ClusterManager {
@Autowired
private RegistryClient registryClient;
+ private WorkerGroupTaskDispatchManager workerGroupTaskDispatchManager;
+
public ClusterManager() {
this.masterClusters = new MasterClusters();
this.workerClusters = new WorkerClusters();
}
- public void start() {
+ public void start(WorkerGroupTaskDispatchManager
workerGroupTaskDispatchManager) {
+ this.workerGroupTaskDispatchManager = workerGroupTaskDispatchManager;
Review Comment:
You should add a method to register the `WorkerGroupListener` rather than
change the start method, this is too strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
