BruceWong96 commented on code in PR #17032:
URL:
https://github.com/apache/dolphinscheduler/pull/17032#discussion_r1992989512
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxParameters.java:
##########
@@ -95,6 +97,11 @@ public class DataxParameters extends AbstractParameters {
*/
private int jobSpeedRecord;
+ /**
+ * channel count
+ */
+ private int channelCount = 1;
Review Comment:
> If so, this PR seems meanless, it doesn't change the usage.
Sorry, I might have misunderstood this issue.
After reviewing the issue, it’s clear that custom configurations are fully
handled through JSON.
Modifying this parameter is only required when using DS’s default
configuration.
To address this, we should add a channel configuration option in the UI to
let users adjust the channel count setting.
Is my understanding correct?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
