yingh0ng commented on code in PR #17058:
URL:
https://github.com/apache/dolphinscheduler/pull/17058#discussion_r2020533941
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/WorkflowGraph.java:
##########
@@ -57,6 +59,22 @@ public WorkflowGraph(List<WorkflowTaskRelation>
workflowTaskRelations, List<Task
addTaskEdge(workflowTaskRelations);
}
+ private void checkIfDAG(List<WorkflowTaskRelation> workflowTaskRelations,
List<TaskDefinition> taskDefinitions) {
+ DAG<Long, TaskDefinition, WorkflowTaskRelation> graph = new DAG<>();
Review Comment:
@ruanwenjun PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
