reele commented on issue #16878:
URL:
https://github.com/apache/dolphinscheduler/issues/16878#issuecomment-2742007174
@ruanwenjun
my mistake...it's not the cause of exception.
use `@Transactional(propagation = Propagation.SUPPORTS)` will work:
```java
@Transactional(propagation = Propagation.SUPPORTS)
public IWorkflowExecutionRunnable createWorkflowExecuteRunnable(Command
command) {
deleteCommandOrThrow(command);
return doCreateWorkflowExecutionRunnable(command);
}
```
i'm still trying to determine why.
my case is migrate from 2.0.6 to dev, so after upgraded schema, workflow
instance's command param missing `commandType`, so the failover command's
execution is failed, but the database didn't rollback:
```log
[WI-0][TI-0] - 2025-03-20 18:08:23.924 ERROR [MasterCommandHandleThreadPool]
o.a.d.s.m.e.c.CommandEngine:[184] - Failed bootstrap command {
"id" : 4316023,
"commandType" : "RECOVER_TOLERANCE_FAULT_PROCESS",
"workflowDefinitionCode" : 10059785789984,
"workflowDefinitionVersion" : 3,
"workflowInstanceId" : 4257960,
"commandParam" :
"{\"commandType\":\"RECOVER_TOLERANCE_FAULT\",\"subWorkflowInstance\":false,\"startNodes\":null,\"commandParams\":null,\"timeZone\":null,\"workflowExecutionStatus\":\"RUNNING_EXECUTION\"}",
"workflowInstancePriority" : "MEDIUM",
"executorId" : 0,
"taskDependType" : "TASK_POST",
"failureStrategy" : "CONTINUE",
"warningType" : "NONE",
"warningGroupId" : null,
"scheduleTime" : null,
"startTime" : null,
"updateTime" : "2025-03-20 18:08:22",
"workerGroup" : null,
"tenantCode" : "default",
"environmentCode" : -1,
"dryRun" : 0,
"testFlag" : 0
}
java.util.concurrent.CompletionException:
java.lang.IllegalArgumentException: Invalid command param : null
at
java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273)
at
java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:280)
at
java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1606)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:750)
Caused by: java.lang.IllegalArgumentException: Invalid command param : null
at
com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)
at
org.apache.dolphinscheduler.server.master.engine.command.handler.AbstractCommandHandler.parseStartNodesFromWorkflowInstance(AbstractCommandHandler.java:135)
at
org.apache.dolphinscheduler.server.master.engine.command.handler.WorkflowFailoverCommandHandler.assembleWorkflowExecutionGraph(WorkflowFailoverCommandHandler.java:134)
at
org.apache.dolphinscheduler.server.master.engine.command.handler.AbstractCommandHandler.handleCommand(AbstractCommandHandler.java:83)
at
org.apache.dolphinscheduler.server.master.engine.workflow.runnable.WorkflowExecutionRunnableFactory.doCreateWorkflowExecutionRunnable(WorkflowExecutionRunnableFactory.java:71)
at
org.apache.dolphinscheduler.server.master.engine.workflow.runnable.WorkflowExecutionRunnableFactory.createWorkflowExecuteRunnable(WorkflowExecutionRunnableFactory.java:56)
at
org.apache.dolphinscheduler.server.master.engine.workflow.runnable.WorkflowExecutionRunnableFactory$$FastClassBySpringCGLIB$$597b7266.invoke(<generated>)
at
org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
at
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:793)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:763)
at
org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:123)
at
org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:388)
at
org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:119)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:763)
at
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:708)
at
org.apache.dolphinscheduler.server.master.engine.workflow.runnable.WorkflowExecutionRunnableFactory$$EnhancerBySpringCGLIB$$e1cd410c.createWorkflowExecuteRunnable(<generated>)
at
org.apache.dolphinscheduler.server.master.engine.command.CommandEngine.lambda$bootstrapCommand$2(CommandEngine.java:151)
at
java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604)
... 3 common frames omitted
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
