yingh0ng commented on code in PR #17132:
URL:
https://github.com/apache/dolphinscheduler/pull/17132#discussion_r2048186828
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java:
##########
@@ -1584,6 +1588,10 @@ protected boolean checkAndImport(User loginUser,
putMsg(result, Status.IMPORT_WORKFLOW_DEFINE_ERROR);
throw new
ServiceException(Status.IMPORT_WORKFLOW_DEFINE_ERROR);
}
+ if (ReleaseState.ONLINE.equals(schedule.getReleaseState())) {
+ Project project = projectMapper.queryByCode(projectCode);
+ schedulerApi.insertOrUpdateScheduleTask(project.getId(),
schedule);
+ }
Review Comment:
I see what you mean. We should throw an exception when the `releaseState` is
online. This would prevent user confusion.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
