Copilot commented on code in PR #16683:
URL:
https://github.com/apache/dolphinscheduler/pull/16683#discussion_r2048321543
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/ParameterUtils.java:
##########
@@ -314,15 +314,18 @@ private static String dateTemplateParse(String
templateStr, Date date) {
/**
* handle escapes
*
- * @param inputString input string
+ * @param str input string
* @return string filter escapes
*/
- public static String handleEscapes(String inputString) {
-
- if (!StringUtils.isEmpty(inputString)) {
- return inputString.replace("%", "////%").replaceAll("[\n|\r\t]",
"_");
+ public static String handleEscapes(String str) {
+ str = StringUtils.trim(str);
+ if (StringUtils.isNotBlank(str)) {
+ str = str.replace("\\", "\\\\");
+ str = str.replace("_", "\\_");
+ str = str.replace("%", "\\%");
+ str = str.replaceAll("[\n|\r\t]", "");
Review Comment:
The regex pattern "[\n|\r\t]" may inadvertently match the '|' character;
consider using "[\n\r\t]" to ensure only newline, carriage return, and tab are
removed.
```suggestion
str = str.replaceAll("[\n\r\t]", "");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
