yingh0ng commented on code in PR #17159:
URL: 
https://github.com/apache/dolphinscheduler/pull/17159#discussion_r2080880879


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/config/MasterServerLoadProtection.java:
##########
@@ -18,10 +18,41 @@
 package org.apache.dolphinscheduler.server.master.config;
 
 import org.apache.dolphinscheduler.meter.metrics.BaseServerLoadProtection;
+import org.apache.dolphinscheduler.meter.metrics.SystemMetrics;
+import 
org.apache.dolphinscheduler.server.master.engine.WorkflowCacheRepository;
 
+import lombok.Getter;
+import lombok.Setter;
 import lombok.extern.slf4j.Slf4j;
 
 @Slf4j
+@Getter
+@Setter
 public class MasterServerLoadProtection extends BaseServerLoadProtection {
 
+    private Integer maxConcurrentWorkflowInstances = Integer.MAX_VALUE;
+
+    private IWorkflowRepository workflowRepository;
+
+    @Override
+    public boolean isOverload(SystemMetrics systemMetrics) {
+        if (!enabled) {

Review Comment:
   Is this necessary? It duplicates in the `super.isOverLoad()` method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to