unigof opened a new issue, #17169:
URL: https://github.com/apache/dolphinscheduler/issues/17169

   ### Search before asking
   
   - [x] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar feature requirement.
   
   
   ### Description
   
   There are two kinds of attribute to keep pre node info in TaskNode:
   ```
   private String preTasks;
   private List<Long> depList;
   ```
   
   And they are be assigned at the same time:
   ```
       public void setPreTasks(String preTasks) {
           this.preTasks = preTasks;
           this.depList = JSONUtils.toList(preTasks, Long.class);
       }
   ```
   
   So, we can use `depList` to replace `preTasks` when iterater pre task node. 
   e.g `graphHasCycle` method in  `WorkflowDefinitionServiceImpl`
   
   ### Are you willing to submit a PR?
   
   - [x] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to