tusaryan commented on issue #17171: URL: https://github.com/apache/dolphinscheduler/issues/17171#issuecomment-2890138268
> > Frontend UI Changes ( dolphinscheduler-ui - Vue.js) - [Essential] > > I think we should keep the style of the current login page and avoid over-design. Just add the authentication channel under the login button and avoid unnessnary change. ✅Will follow your suggestion to simply add the OIDC authentication options under the existing login button, ensuring unnecessary changes are avoided. > > Testing (Unit & E2E) - [Essential] > > 1. UT is a necessity for every PR. ✅ I fully understand will provide unit test in every PR. > 2. E2E test or API test is required in the first PR. You can choose any way to realize it, just aim at one of the authentication channels. API test will be simpler, I suggest you choose this one. > [E2E-Test](https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-e2e/README.md) [API-Test](https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-api-test/README.md) ✅ Agree with your approach and will proceed as you suggested. I will implement API tests, focusing on one authentication channel as you advised. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
