SbloodyS commented on code in PR #17320:
URL:
https://github.com/apache/dolphinscheduler/pull/17320#discussion_r2188804704
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/ProcessUtils.java:
##########
@@ -56,6 +56,9 @@
@Slf4j
public final class ProcessUtils {
+ // Wait 5 seconds to check process status
+ private static final int CHECK_PROCESS_WAITING_MILLIS = 5000;
Review Comment:
Explicit waiting is not a good way for user experience. Some programs take
some time to shut down gracefully. We should set this as an implicit wait and
put this time in the configuration file for the user to configure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
