njnu-seafish commented on code in PR #17320:
URL:
https://github.com/apache/dolphinscheduler/pull/17320#discussion_r2209385125
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/test/java/org/apache/dolphinscheduler/plugin/task/api/utils/ProcessUtilsTest.java:
##########
@@ -132,7 +132,7 @@ void testKillProcessSuccessWithSigInt() throws Exception {
boolean result = ProcessUtils.kill(taskRequest);
// Assert
- Assertions.assertTrue(result);
+ Assertions.assertFalse(result);
Review Comment:
> Why change the assertion? Please fix the test case.
update the test case, it is ok now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
