njnu-seafish commented on code in PR #17362:
URL:
https://github.com/apache/dolphinscheduler/pull/17362#discussion_r2227069208
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/shell/AbstractShell.java:
##########
@@ -201,8 +201,10 @@ public void run() {
completed.compareAndSet(false, true);
// the timeout thread handling
// taken care in finally block
- if (exitCode != 0 || errMsg.length() > 0) {
+ if (exitCode != 0) {
Review Comment:
> Please avoid unnessnary change.
Alright, we'll leave it unchanged for the time being.
According to the logic used here, similar bugs will indeed occur:
exitCode=0 but errMsg is not null.
if (exitCode != 0 || errMsg.length() > 0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
