SbloodyS commented on code in PR #17339:
URL:
https://github.com/apache/dolphinscheduler/pull/17339#discussion_r2281433570
##########
.github/workflows/e2e-k8s.yml:
##########
@@ -94,65 +94,98 @@ jobs:
kind create cluster --name dolphinscheduler --image
${kind_node_image}
kubectl version
kubectl get all --all-namespaces
- - name: Load images
+
+ - name: Build dolphinscheduler images with MySQL driver
run: |
+ wget -O mysql-connector-java-8.0.16.jar
https://repo1.maven.org/maven2/mysql/mysql-connector-java/8.0.16/mysql-connector-java-8.0.16.jar
components=("master" "worker" "api" "tools" "alert-server")
+ registry="apache"
for component in "${components[@]}"; do
- kind load docker-image apache/dolphinscheduler-${component}:ci
--name dolphinscheduler
+ if [ "$component" = "tools" ]; then
+ mkdir -p dolphinscheduler-tools
+ cp mysql-connector-java-8.0.16.jar dolphinscheduler-tools/
+ echo -e "FROM $registry/dolphinscheduler-tools:latest\nCOPY
../mysql-connector-java-8.0.16.jar /opt/dolphinscheduler/tools/libs/" >
dolphinscheduler-tools/Dockerfile
+ docker build -t $registry/dolphinscheduler-tools:ci
dolphinscheduler-tools
+ else
+ mkdir -p dolphinscheduler-$component
+ cp mysql-connector-java-8.0.16.jar dolphinscheduler-$component/
+ echo -e "FROM
$registry/dolphinscheduler-$component:latest\nCOPY
../mysql-connector-java-8.0.16.jar /opt/dolphinscheduler/libs/" >
dolphinscheduler-$component/Dockerfile
+ docker build -t $registry/dolphinscheduler-$component:ci
dolphinscheduler-$component
+ fi
+ kind load docker-image apache/dolphinscheduler-$component:ci
--name dolphinscheduler
done
- - name: Helm install dolphinscheduler
- working-directory: ${{ github.workspace
}}/deploy/kubernetes/dolphinscheduler
+ - name: Deploy standalone MySQL on K8s
Review Comment:
> Why was Mysql used to replace PostgreSQL? Wouldn't it be better to apply
the matrix feature of github actions to test both Mysql and PostgreSQL at the
same time?
+1, matrix is nesssnary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
