njnu-seafish commented on code in PR #17437:
URL:
https://github.com/apache/dolphinscheduler/pull/17437#discussion_r2312824631
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/ProcessUtils.java:
##########
@@ -115,13 +115,14 @@
// Get all child processes
String pids = getPidsStr(processId);
String[] pidArray = PID_PATTERN.split(pids);
- if (pidArray.length == 0) {
+ if (StringUtils.isBlank(pids) || pidArray.length == 0) {
log.warn("No valid PIDs found for process: {}", processId);
return true;
}
// Convert PID string to list of integers
- List<Integer> pidList =
Arrays.stream(pidArray).map(Integer::parseInt).collect(Collectors.toList());
+ List<Integer> pidList =
Arrays.stream(pidArray).filter(StringUtils::isNotBlank).map(Integer::parseInt)
Review Comment:
List<Integer> pidList =
Arrays.stream(pidArray).filter(StringUtils::isNotBlank)
.map(s -> {
try {
return Integer.parseInt(s.trim());
} catch (NumberFormatException e) {
log.warn("Invalid PID string ignored: {}", s);
return null;
}
})
.filter(Objects::nonNull)
.collect(Collectors.toList());
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
