dill21yu commented on issue #16706: URL: https://github.com/apache/dolphinscheduler/issues/16706#issuecomment-3279782690
Could you let me know if this approach looks good? @SbloodyS @ruanwenjun add a checkMode field to differentiate between “ANY_SUCCESS” and “ALL_SUCCESS” requirements while maintaining backward compatibility. <html> <body> <!--StartFragment--><p style="line-height: 1.5; margin-top: 0px; color: rgb(55, 65, 81); font-family: "Microsoft YaHei", 微软雅黑, Arial, sans-serif; font-size: 14px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;"><strong>Behavior Examples</strong>:</p> dateValue | checkMode | Meaning | Legacy Equivalent -- | -- | -- | -- last7Days | ANY_SUCCESS | Any single success in 7 days (default) | Original anyTimeLast7Days last7Days | ALL_SUCCESS | Requires success every day in 7d | N/A (new) last1Month | ANY_SUCCESS | Any success in the last month | Original lastMonth <!--EndFragment--> </body> </html> Advantages: Full backward compatibility: Old configs default to ANY_SUCCESS. Clear separation: type = time window, checkMode = validation logic. Scalable: Future time units (e.g., lastNHours) need no duplicate types. Why no _Period suffix types? Avoids redundancy (e.g., last7Days + last7DaysPeriod). Default ANY_SUCCESS preserves legacy behavior. Thanks for the discussion! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
