nauu commented on a change in pull request #3169:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3169#discussion_r452631905
##########
File path:
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml
##########
@@ -36,7 +36,12 @@
</foreach>
order by id asc
</select>
-
+ <select id="queryTopNProcessInstanceOrderByDuration"
resultType="org.apache.dolphinscheduler.dao.entity.ProcessInstance">
+ select *
Review comment:
According to the definition of tasks, the top n here should only query
tasks in succes state, and can filter according to time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]