ruanwenjun commented on code in PR #17541:
URL:
https://github.com/apache/dolphinscheduler/pull/17541#discussion_r2379083060
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/WorkflowGraphTopologyLogicalVisitor.java:
##########
@@ -143,7 +143,11 @@ private void doVisitationInSubGraph(Set<String>
subGraphNodes) {
if (!visitedTaskCodes.contains(taskName)) {
visitedTaskCodes.add(taskName); // Record the nodes
final Set<String> successors =
workflowGraph.getSuccessors(taskName);
- if (subGraphNodes.contains(taskName)) {
+ // In TASK_ONLY mode, pass empty successors since there are no
subsequent nodes
+ if (taskDependType == TaskDependType.TASK_ONLY) {
+ final Set<String> emptySuccessors = new HashSet<>();
+ visitFunction.accept(taskName, emptySuccessors);
+ } else {
Review Comment:
The `subGraphNodes` should be only one node in this case, so only node in
`subGraphNodes` will be visit, is this bug caused by here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
